Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510038 Gary T. Giesen <giesen@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giesen@xxxxxxxxxxxx --- Comment #1 from Gary T. Giesen <giesen@xxxxxxxxxxxx> 2009-07-08 01:00:18 EDT --- This is a mock review. I do not have permissions to approve the package: MUST: rpmlint must be run on every package. The output should be posted in the review. OK rpmlint -i SPECS/python-icalendar.spec SRPMS/python-icalendar-2.0.1-0.1.fc11.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. MUST: The package must be named according to the Package Naming Guidelines . OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec OK MUST: The package must meet the Packaging Guidelines . OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK MUST: The License field in the package spec file must match the actual license. NEEDSWORK According to README.txt and LICENSE.txt, this is LGPLv2+ MUST: The source package includes the text of the license(s) in its own file, and then that fileis included in %doc. NEEDSWORK %doc should include CHANGES.txt, CREDITS.txt, HISTORY.txt, LICENSE.txt, PKG-INFO, README.TXT, TODO.txt, version.txt MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. NEEDSWORK Timestamps of source package do not match. See http://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps Suggest using wget -N http://pypi.python.org/packages/source/i/icalendar/icalendar-2.0.1.tar.gz MUST: Binary RPM package which stores shared library files in any of the dynamic linker's default paths, must call ldconfig. N/A MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. N/A MUST: A package must own all directories that it creates. If it does not create a directory that it uses or require the package which does create that directory. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. OK MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). N/A MUST: If a package contains library files with a suffix, then library files that end in .so (without suffix) must go in a -devel package. N/A MUST: Devel packages must require the base package using a fully versioned dependency: N/A MUST: Packages must NOT contain any .la libtool archives. OK MUST: Packages containing GUI applications must include a %{name}.desktop file and be installed properly. N/A MUST: Packages must not own files or directories already owned by other packages. N/A MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK MUST: All filenames in rpm packages must be valid UTF-8. OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review