Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508483 Christian Krause <chkr@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #12 from Christian Krause <chkr@xxxxxxxxxxx> 2009-07-07 15:46:59 EDT --- Hi John, > Here are the new URLs: I've reviewed the latest package and all issues brought up during the review were addressed and fixed. Just one additional suggestion I've overseen before: To include the libraries in the %files sections you can better write: in %files: %{_libdir}/*.so.* instead of %{_libdir}/libewl.so.1 %{_libdir}/libewl.so.1.0.0 and in %files devel: %{_libdir}/*.so But since this is really quite subjective and there is no explicit rule about it, I don't think another review cycle is necessary. Please import the package as it was reviewed into CVS and if you like you can do this minor enhancement later. Regarding: > http://www.guthrie.info/RPMS/f11/ewl.spec > http://www.guthrie.info/RPMS/f11/ewl-0.5.2.042-9.fc11.src.rpm the package is: -> APPROVED Best regards. Christian -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review