Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507052 --- Comment #3 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2009-07-07 04:14:03 EDT --- (In reply to comment #2) > A new version is here : 0.71.100 > > %prep > try to keep timestamp when using %{__sed} -i 's/\r//' Done > > It shouldn't be needed to use CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS to > use our opt flags(at least on recent Fedora). > removed > License Field is GPLv2+ (which match source code header) but GPLv3 text file is > redistributed. (need to check lastest version) > GPLv3. Its been clarified in the latest version. > Please submit .desktop and icon upstream or pick the one from the package if > available. Submitted them. If the upstream does not provide them, I need to make them ? I got them from http://hanzlici.cz/packages/fedora/panini/ this time. > > Try to have the compiled binary / pixmaps installed with make install at > %install step. I'm not sure on how to do this. The package generates a makefile using qmake-qt4. I need to patch this generated makefile before make uses it?? the srpm: http://ankursinha.fedorapeople.org/panini/Panini-0.71.102-1.fc12.src.rpm the spec: http://ankursinha.fedorapeople.org/panini/Panini.spec all other files, (logs and the desktop and icon etc.) are at http://ankursinha.fedorapeople.org/panini/ regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review