Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509739 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jussi.lehtola@xxxxxx Flag| |fedora-review? --- Comment #2 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-07-05 14:53:23 EDT --- - You don't need to specify -n daemonize-%{version} in %setup, as this is the default value. - What is $common_flags doing in %configure? - You are using incorrect characters in the description: change ’ to ' and “ to ". - The provide Provides: daemonize is redundant, since by default all packages provide themself (with a versioned provide). I can sponsor you, if you show me you know the Fedora guidelines. You need to read and understand the packaging and review guidelines, and to demonstrate your knowledge you need to make at least one other submission, and do unofficial package reviews of packages of other people. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review