Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503136 --- Comment #3 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-07-05 09:52:09 EDT --- Whoops, sorry for the delay, somehow this slipped under my radar. - Use the %{version} macro in Source0. - You have duplicate ownership of files in %{_sysconfdir}/csync. As you specify the files in that directory, just change %{_sysconfdir}/csync to %dir %{_sysconfdir}/csync/ (I recommend using the trailing slash whenever listing a directory, makes the spec file easier to read). - You might want to put an explicit require on the libs package in the main package, since the license is in -libs. - There is a test option, so you should use it. You probably need just BR: check(-devel?) and then the section %check make test - Is the config used just by the binary or by the libraries too? **** rpmlint output: csync-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 1 warnings. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. NEEDSWORK - Change the Source0 line to use %{version}. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK MUST: Packages containing shared library files must call ldconfig. OK MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. NEEDSWORK - Duplicate ownership as stated above. MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. NEEDSWORK - Missing AUTHORS and TODO. MUST: Header files must be in a -devel package. OK MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. OK MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. OK - Libs package required. MUST: Packages does not contain any .la libtool archives. N/A MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK - Only builds in rawhide due to missing iniparser package in <=F11. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review