Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484226 --- Comment #3 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> 2009-07-04 17:04:45 EDT --- Here is further review + Permissions on files are properly set with the use of %defattr(...) line. + Package has a %clean section containing rm -fr %{buildroot} + Use of macros is consistent + Package contains code + There is no large documentation + Files inside %doc do not affect runtime + No header files nor static libraries + No .la libtool archives + Package does not contain GUI application + Package does not own files or directories already owned by other packages. + At the beginning of %install, package has rm -rf %{buildroot} + All filenames in rpm packages are valid UTF-8. Before approval, would you mind to give the list of command for ruby-icon-artists and what does it do in Inkscape? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review