Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508750 Christian Krause <chkr@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chkr@xxxxxxxxxxx --- Comment #4 from Christian Krause <chkr@xxxxxxxxxxx> 2009-07-03 06:10:23 EDT --- I would volunteer to do this review. I had a quick look at the package and here are some thoughts: * Did you hear anything from upstream regarding 0.11.2? * The package includes the script "volume-of" which - does not work (wrong python module imported) - has a very generic name - does not seem to be necessary - is not mentioned in the README.txt - has no manpage I think it can be omitted. ;-) * The URL of Source0 is different from the download URL mentioned on the homepage of the project: http://trash-cli.googlecode.com/files/trash-cli-0.11.1.2.tar.gz * the usage of %{__...} commands should be consistent - either use them entirely or omit them completly (the usage of %{__python} for determining python_sitelib is ok, since it is consistent with the packaging guidelines, however, I would not use %{__sed} ...) * Please add a short comment regarding the changes to the source files in the %prep section * What's the difference between trash-restore and restore-trash in the package? The latter doesn't have a man-page... * IMHO the usage of %{pyver} could be omitted, just use e.g. %{python_sitelib}/trash_cli*.egg-info -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review