Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509520 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-07-03 05:51:11 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1452266 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 11dd5d100994dc3f5dcf56b53831f876e9e1fb84 CGI-Application-Plugin-LogDispatch-1.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=8, Tests=30, 1 wallclock secs ( 0.06 usr 0.00 sys + 0.82 cusr 0.06 csys = 0.94 CPU) + Package perl-CGI-Application-Plugin-LogDispatch-1.02-1.fc12.noarch => Provides: perl(CGI::Application::Plugin::LogDispatch) = 1.02 Requires: perl(CGI::Application) perl(File::Spec) perl(Log::Dispatch) perl(Log::Dispatch::Screen) perl(Scalar::Util) perl(UNIVERSAL::require) perl(strict) perl(vars) + Not a GUI application Suggestions: 1) looks this package needs Requires: perl(Sub::WrapPackages) Requires: perl(Class::ISA) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review