Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506486 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #7 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-07-03 02:21:32 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1452075 - rpmlint is NOT silent for SRPM and for RPM. mojito.src: W: invalid-license LGPLv2.1 mojito.i586: W: invalid-license LGPLv2.1 mojito-devel.i586: W: invalid-license LGPLv2.1 == Fix it to LGPLv2 + source files match upstream url 6fcc6b5b439bd95d18901aa2ee7f2241e381a02a mojito-0.10.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + mojito-client.pc and mojito-module.pc files present. + -devel subpackage present. + no .la files. + no translations are available + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package mojito-0.10.3-2.fc12.i586 => Provides: libmojito-client.so.1 libmojito-service-dummy.so libmojito.so.0 libtwitter.so Requires(interp): /sbin/ldconfig /sbin/ldconfig Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libdbus-1.so.3 libdbus-glib-1.so.2 libgconf-2.so.4 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libjson-glib-1.0.so.0 libmojito-client.so.1 libmojito.so.0 libpthread.so.0 librt.so.1 libsoup-2.4.so.1 libsoup-gnome-2.4.so.1 libtwitter-glib-1.0.so.0 rtld(GNU_HASH) + Package mojito-devel-0.10.3-2.fc12.i586 => Provides: pkgconfig(mojito-client) = 0.10.3 pkgconfig(mojito-module) = 0.10.3 Requires: /usr/bin/pkg-config libmojito-client.so.1 libmojito.so.0 pkgconfig(dbus-glib-1) pkgconfig(glib-2.0) pkgconfig(libsoup-2.4) + Not a GUI application Should: 1) Fix rpmlint warnings. 2) you can also add examples and tests sample code to %doc of -devel package as %doc tests/*.c examples/*c examples/*.py APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review