Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507260 --- Comment #5 from Ian Weller <ian@xxxxxxxxxxxxx> 2009-07-01 20:22:00 EDT --- == FULL REVIEW == [ OK ] specfiles match: 603f646439e75ee959296cb4ec71b153 wordpress-mu-plugin-defaults.spec 603f646439e75ee959296cb4ec71b153 wordpress-mu-plugin-defaults.spec.1 [ OK ] source files match upstream: b0ecafbc0ccdf226046474aab0d7f7a7 503434057_cets_new_blog_defaults.zip b0ecafbc0ccdf226046474aab0d7f7a7 503434057_cets_new_blog_defaults.zip.1 [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [ N/A ] license text included in package. License text not provided so not necessary to be in %doc [ OK ] latest version is being packaged. [ N/A ] BuildRequires are proper. [ N/A ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. [ OK ] package installs properly. [ N/A ] debuginfo package looks complete. [FAILED] rpmlint is silent. wordpress-mu-plugin-defaults.noarch: W: incoherent-version-in-changelog 1.2.3-1 ['1.2.3-2.fc11', '1.2.3-2'] You need to add a changelog entry for each update (including the fix-the-description update). Add a changelog entry that you fixed the changelog as well and bump it for me to approve this package. [ OK ] final provides and requires are sane [ N/A ] %check is present and all tests pass: [ OK ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ N/A ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] no headers. [ OK ] no pkgconfig files. [ OK ] no libtool .la droppings. [ OK ] desktop files valid and installed properly. Not approved, see above -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review