Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-gef - Eclipse Graphical Editing Framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204525 green@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(overholt@xxxxxxxxx| |m) | ------- Additional Comments From green@xxxxxxxxxx 2006-09-06 19:28 EST ------- Almost there :-) See the lines starting with "X". * package meets and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. X dist tag is not present. Add %{?dist} to Release tag. X build root is not correct. Use... %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * license field matches the actual license. * license is open source-compatible. * License text included in package. * source files match upstream (extracted from upstream cvs so no md5sum available.) * latest version is being packaged. * BuildRequires are proper. * package builds in mock ( ). X rpmlint on eclipse-gef says: W: eclipse-gef-sdk no-documentation It looks like you put the %docs in the examples package instead of the eclipse-gef package. * final provides and requires are sane: eclipse-gef-3.2.0-2.i386.rpm org.eclipse.draw2d_3.2.0.R32_Maintenance.jar.so org.eclipse.gef_3.2.100.R32_Maintenance.jar.so eclipse-gef = 3.2.0-2 = /usr/bin/rebuild-gcj-db /usr/bin/rebuild-gcj-db eclipse-platform eclipse-platform >= 1:3.2.0 java-gcj-compat >= 1.0.33 java-gcj-compat >= 1.0.33 eclipse-pde gcc-java >= 4.0.2 java-gcj-compat-devel >= 1.0.33 eclipse-gef-examples-3.2.0-2.i386.rpm org.eclipse.gef.examples.flow_3.2.0.R32_Maintenance.jar.so org.eclipse.gef.examples.logic_3.2.0.R32_Maintenance.jar.so org.eclipse.gef.examples.shapes_3.2.0.R32_Maintenance.jar.so org.eclipse.gef.examples.text_3.2.0.R32_Maintenance.jar.so eclipse-gef-examples = 3.2.0-2 = eclipse-gef = 3.2.0-2 eclipse-gef-sdk = 3.2.0-2 eclipse-gef-sdk-3.2.0-2.i386.rpm eclipse-gef-sdk = 3.2.0-2 = eclipse-gef = 3.2.0-2 * shared libraries are present, but no ldconfig required. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present * scriptlets OK * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app (no .desktop file required). * not a web app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review