[Bug 509158] New: Review Request: gnat-project-common – files shared by Ada libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: gnat-project-common – files shared by Ada libraries

https://bugzilla.redhat.com/show_bug.cgi?id=509158

           Summary: Review Request: gnat-project-common – files shared by
                    Ada libraries
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: nobody@xxxxxxxxxxxxxxxxx
        ReportedBy: bjorn@xxxxxxxxxxxxxxxxxxxx
         QAContact: extras-qa@xxxxxxxxxxxxxxxxx
                CC: notting@xxxxxxxxxx, fedora-package-review@xxxxxxxxxx
   Estimated Hours: 0.0
    Classification: Fedora


Spec URL: http://www.rombobjörn.se/packages/gnat-project-common.spec
SRPM URL:
http://www.rombobjörn.se/packages/gnat-project-common-1-1.fc11.src.rpm

Description:
The gnat-project-common package contains some small files that help a GNAT
project file to work for both 32-bit and 64-bit versions of an Ada library. The
plan is that all -devel packages with Ada libraries will use these files. So
far they are used by PragmARC-devel.

The package also adds a couple of RPM macros to help with packaging Ada
programs and libraries.

RPMlint output:
gnat-project-common.spec: E: no-buildroot-tag
Since RPMbuild now ignores the buildroot tag I don't see why I would need one.

gnat-project-common.noarch: W: no-url-tag
This package contains 17 lines of code in total, written by me specifically for
Fedora. Do I still need to set up a website for it?

gnat-project-common.noarch: W: only-non-binary-in-usr-lib
There are no compiled libraries in this package but there is a GNAT project
file, and GNAT looks for project files in /usr/lib/gnat so that's where I need
to put it. It could be argued that /usr/share/gnat would be a better location
but that would require a change in GNAT.

gnat-project-common.noarch: W: no-documentation
There is documentation in the form of comments in the files, which is where I
think it belongs for the time being.

gnat-project-common.noarch: W: non-conffile-in-etc
/etc/profile.d/gnat-project.sh
gnat-project-common.noarch: W: non-conffile-in-etc
/etc/profile.d/gnat-project.csh
gnat-project-common.noarch: W: non-conffile-in-etc /etc/rpm/macros.gnat
I suppose it could be debated whether those are configuration files or program
code, but they need to be in these directories to be effective.

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1447086

I should also mention that I need a sponsor.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]