Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502490 Michal Ingeli <mi@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mi@xxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mi@xxxxx Flag| |fedora-review? --- Comment #1 from Michal Ingeli <mi@xxxxx> 2009-06-30 19:30:04 EDT --- - bad license. should be MIT [1] - missing require for ruby(abi) - file listed twice warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4/LICENSE - rubygem-state_machine.src: W: mixed-use-of-spaces-and-tabs (spaces: line 33, tab: line 7) You can inspire by review made by Mamoru Tasaka for recent ruby gem review [2]. [1] https://fedoraproject.org/wiki/Licensing/MIT#Modern_Style_with_sublicense [2] https://bugzilla.redhat.com/show_bug.cgi?id=504469 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review