Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455227 --- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> 2009-06-30 10:46:02 EDT --- Jason Tibbitts, thank you very much for the review. (In reply to comment #4) > These days %global seems to be preferred over %define, though the differences > are subtle and I don't think it makes any particular difference for the two > %defines you're using. Ok, let it be %global. > > I think your Source0 should not be a URL if that URL is not valid, such as in > the case where you're using a CVS snapshot. Fixed. > > I'm not sure why you'd need "PECL:" in the Summary; the upstream site doesn't > use that in its summary, and it gives the impression that the name of the > package is "PECL". Ok, "PECL" prefix removed. > > Your BuildRoot: tag is missing any mention of %release. One day soon BuildRoot > can go away, but that's not quite here yet and in the meantime it needs to meet > the guidelines. > https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Added %%release part into BuildRoot tag. http://hubbitus.net.ru/rpm/Fedora10/php-pecl-parsekit/php-pecl-parsekit-1.2-3.CVS20090309.fc9.src.rpm http://hubbitus.net.ru/rpm/Fedora10/php-pecl-parsekit/php-pecl-parsekit.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review