Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507958 Andrew Overholt <overholt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |overholt@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |overholt@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Andrew Overholt <overholt@xxxxxxxxxx> 2009-06-29 13:54:47 EDT --- Thanks for the submission, Jeff. A few comments: - I think you're missing Requires on eclipse-cdt and eclipse-emf - will we move to 3.1 once we get a Galileo CDT build? - please use either %{buildroot} or $RPM_BUILD_ROOT but not both - we should perhaps have Eclipse in the Summary field - I think "framework" can be dropped from the Summary field - please change the permissions on the fetch script to avoid this rpmlint warning: eclipse-rse.src: W: strange-permission fetch-rse.sh 0775 - you should probably mark a top-level feature's about.html as %doc - you should look for @build@ and replace it with the same qualifier that upstream uses. In fact, you should use forceContextQualifier (see eclipse-mylyn.spec for an example) to ensure our versions are the same as upstream's for 3.0.3 The package builds for me, follows the packaging guidelines, and functions in Eclipse. Thanks for the high quality submission. Once the minor issues above are cleaned up, I will approve this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review