Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504473 --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-06-28 15:11:20 EDT --- Some notes for 1.5.2-3: * License tag - As website/javascripts/rounded_corners_lite.inc.js is under LGPLv2+, license tag should be "MIT and LGPLv2+". * Requires - rubygem(hoe) doesn't seem to be needed. Would you check this? * Test - I think as this gem file contains test/ directory, it is preferable to add %check section and execute some tet program there (another gem seems needed, though) By the way, I would appreciate it if you would review my review requests (bug 508416 or bug 508417, both are rubygem related) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review