[Bug 508188] Review Request: pywbem - Python WBEM Client and Provider Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508188


Jason Tibbitts <tibbs@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #6 from Jason Tibbitts <tibbs@xxxxxxxxxxx>  2009-06-28 13:40:37 EDT ---
Hmm, note that page on unnecessary byte compilation includes a link to the bug,
which you may note was closed back in March.  I know the issue was fixed in
rawhide; I'm pretty sure that happened before F11 branched, so F11 should have
the fix as well.  

Note that you picked up a new rpmlint warning:
  pywbem.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 13)
which I don't care at all about, but you might.

I suppose you could fix setup.py to install those executables in the proper
place for executables, or petition upstream to do so, or do what Tim's package
did and just link to them.  Or leave things the way you have them; I don't
think it makes a significant difference, although the current method has the
dangling .pyc and .pyo files with no corresponding .py file which does seem a
bit odd.  

Otherwise this still builds and installs, and the major issues have been fixed,
so I think this is fine.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]