Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507544 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ --- Comment #2 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-06-27 03:04:17 EDT --- Builds fine and rpmlint is silent. I would suggest a tweaked %description with better grammar and capitalization: The Hilbert curve module provides some useful functions using Hilberts space- filling Curve. This is handy for things like dithering, flattening n-dimensional data, fractals - all kinds of things really. That's terribly minor, so you can fix it up if you like when you check in. * source files match upstream. sha256sum: 455c2932e99a4b1609f5b17176b49a18e99fd8af06c76f161d5083d25b57d825 Math-Curve- Hilbert-0.04.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. x description could use some minor tweaks. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Math::Curve::Hilbert) = 0.04 perl-Math-Curve-Hilbert = 0.04-1.fc12 = perl(:MODULE_COMPAT_5.10.0) perl(Data::Dumper) perl(strict) perl(vars) * %check is present and all tests pass. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review