Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506581 --- Comment #1 from Christian Krause <chkr@xxxxxxxxxxx> 2009-06-26 12:07:50 EDT --- Hi, I've reviewed the package and it looks quite good. There are only minor TODOs: - clarification about the license (I've sent a mail to fedora-legal.) - description formatting - functional test - if possible it would be great if the package would compile in F10, too... Here is the detailed review: * rpmlint: OK rpmlint SPECS/xscope.spec RPMS/i586/xscope-* SRPMS/xscope-1.1-1.gitfccbbd6.fc11.src.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings. * naming: OK - name matches upstream - spec file name matches package name - snapshot release tag OK according: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages * License: TODO - Although the meaning of the license seems to match the BSD license, I'm not 100% sure its a real BSD license since the wording is different. Just to confirm I've asked on the fedora-legal list for confirmation. - COPYING file packaged * specfile in American English and legible: OK * %description: TODO (minor) - I would reformat the last sentence in the %description section to use up the available space of 80 charaters. * Sources: OK - Source0 URL ok - spectool -g xscope.spec works - sources matches upstream - md5sum: c37ec177b56d5909584c1672b6beabd5 xscope-1.1.tar.bz2 * Patch0: OK - patch file can be regenerated by the supplied git diff command - upstream status of the patch is obvious fce6e9df7881061013f4acd43742585b xscope-1.1-diff_to_git.patch * Compilation: OK - mock build works - package builds correctly in koji for F12 and F11, but failed for F10 - RPMOPTFLAGS used - parallel build supported via _smp_mflags * debuginfo sub-package: OK - non-empty - debuginfo file works together with gdb * BuildRequires: OK * Locales handling: OK (n/a) * shared/static libs, pkgconfig/header/*.la files: OK (n/a) * packages must own all directories: OK * files not listed twice: OK * permissions of files: OK - %defattr used - final file permissions OK * %clean section: OK * macro usage: OK * code vs. content: OK (only code) * large documentation into subpackage: OK (n/a) * GUI application needs %{name}.desktop: OK (n/a) * no directories owned which are already owned by other packages: OK * rm -rf %{buildroot} at the beginning of %{install}: OK * all filenames UTF8: OK * functional test: TODO - running it on the same machine as the X server did not work well: - started "xscope -v1" - started "DISPLAY=:1 gedit" in another console - xscope displays some X11 protocol communication - but gedit doesn't start up completly, X server + xscope + gedit hangs, it is necessary to kill xscope by logging in via ssh... - probably it is just wrong usage - any hints welcome ;-) Best regards, Christian -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review