Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482216 --- Comment #22 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-06-25 22:23:54 EDT --- Rakesh, I'm sorry I noticed a few things that I should have noticed before. * The directory %{python_sitearch}/enthought/ is not owned! * No icons specified in the .desktop files. This is not a blocker but it would be really nice to have an icon in the desktop menu for Mayavi. Also, without icons those scriptlets we used have little meaning. I think we can use ./docs/source/mayavi/images/mayavi2-48x48.png from the source tree. Put it in %{_datadir}/icons/hicolor/48x48/apps/mayavi2.png and add Icon=mayavi2 to both .desktop files (unless you want to use a different icon for tvtk) * As for the Categories tag in the .desktop files, it would be good to add some more specific category names, so that the application ends up at a better place in the desktop menu. "Gnome" is too general for this kind of an application, also I have no idea how other DE's will handle it. I would suggest using Science,DataVisualization You may find other suitable categories at http://standards.freedesktop.org/menu-spec/latest/apa.html Again, I'm sorry, I should have told you these things earlier. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review