Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507761 Jan Klepek <jan.klepek@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |504469 --- Comment #3 from Jan Klepek <jan.klepek@xxxxxx> 2009-06-24 14:32:48 EDT --- (In reply to comment #2) > For 0.8.312-1: > > * %define -> %global > - We now recommend to use %global instead of %global: > > https://fedoraproject.org/wiki/Packaging/Ruby#Build_Architecture_and_File_Placement > https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define - Fixed > * License > - From lib/term/ansicolor.rb, the license tag should be > "GPLv2" > - lib/term/ansicolor.rb will be provided by package rubygem-term-ansicolor ( https://bugzilla.redhat.com/show_bug.cgi?id=504469 ). i have added ruby(term-ansicolor) into requires and during %install is directory lib/term removed. I give there LGPLv2 license as this license is specified on web of project and in LICENSE file > * Moving some document files > - Would you explain why you want to move README or so from %geminstdir > to %gemdir/doc ? > Note that $ gem contents coderay expects that those (README or so) files > are under %geminstdir. - - Fixed > * %files > - As you already defined %geminstdir, please use it also in %files > instead of using %{gemdir}/gems/%{gemname}-%{version}/ - Fixed > ! Summary > ---------------------------------------------------------------- > I try to make CodeRay easy to use and intuitive, .... > ---------------------------------------------------------------- > - It is ambiguous what "I" mean here... - Fixed Spec URL: http://hpejakle.fedorapeople.org/packages/rubygem-coderay.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/rubygem-coderay-0.8.312-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review