Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484511 Rakesh Pandit <rpandit@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #10 from Rakesh Pandit <rpandit@xxxxxxxxxx> 2009-06-24 04:11:40 EDT --- http://ivazquez.fedorapeople.org/packages/crunchyfrog/crunchyfrog.spec http://ivazquez.fedorapeople.org/packages/crunchyfrog/crunchyfrog-0.3.4-1.src.rpm I am reviewing ivazquez's files: 1. Why is %{dist} missing from srpm ? 2. License snippet from code says "# the Free Software Foundation, either version 3 of the License, or # (at your option) any later version. " that means GPLv3+ 3. may you check http://fedoraproject.org/wiki/Packaging/ScriptletSnippets & http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files for icon also you need hicolor-* dependency .. may you check the spec file in #8 Thanks, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review