Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485638 Chess Griffin <chess@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chess@xxxxxxxxxxxxxxxx --- Comment #11 from Chess Griffin <chess@xxxxxxxxxxxxxxxx> 2009-06-23 23:03:52 EDT --- Hello- I cannot give you an official review, but here are a few minor nits: You have "Source:" and "Patch0:" (one has 0 and one does not). The documentation[1][2] references "Source0:" even there is only one source download. Either way, they should be consistent, so you may want to change "Source:" to "Source0:". Additionally, (and this is a very minor quibble), you have some parts of the spec file with one blank line between sections and other parts with two. Personally, I would stick with one style or the other. It just looks cleaner. FWIW, I would love to see this package in Fedora. :-) [1] http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo [2] http://fedoraproject.org/wiki/Packaging/SourceURL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review