Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506939 --- Comment #6 from Harald Hoyer <harald@xxxxxxxxxx> 2009-06-23 01:53:25 EDT --- > - License - GPLv2+ > - License field in spec matches - *** > > *** The license in the code is GPLv2 or later; the spec tag should be GPLv2+. > It's also not present in most of the shell snippets; unsure what the > requirements are there. fixed > - Spec in American English - *** > > generic package description: > This package requires everything, which is needed to build a generic > all purpose initramfs. > > Should probably be 'everything that is needed', without the comma. changed > - Package needs ExcludeArch - *** > > *** The arch/noarch switching seems a bit odd. Can we just get a new util-linux > in so we don't need this? left in until util-linux-ng provides switch_root > The 'generic' package really should be some sort of Suggests/Enhances on the > main package. Alas, we can't do that yet. (Requiring to pull in nbd seems > wrong.) The idea is to generate a "generic" dracut image with every kernel build, so that the user does not have to build his own, though he can do it. > > That being said, if we don't have some sort of requirements on lvm2, raid, etc. > tools in the main package, the ordering won't be right on kernel installs, and > it will try to build a non-generic initramfs when the tools haven't yet been > installed that may be needed for that system. This needs solved before we ship > it. add the mkinitrd Requires to the basic dracut rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review