Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505848 --- Comment #6 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-06-22 14:51:16 EDT --- Well, - For this package adding "INSTALL='install -p'" to 'make install' makes little sense, because "make install" just installs compiled binary file. What I said here is that for example at the line below: --------------------------------------------------------------- %{__install} -m 644 %{pecl_name}.xml %{buildroot}%{pecl_xmldir}/%{name}.xml --------------------------------------------------------------- you should use "%{_install} -p -m 644". - And forgot to mention but please use %{__make}, %{__mv}, %{__rm} for consistency. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review