Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493246 --- Comment #17 from Liang Suilong <liangsuilong@xxxxxxxxx> 2009-06-22 02:57:02 EDT --- (In reply to comment #16) > (In reply to comment #15) > > (In reply to comment #14) > > > 1] why do you have download_version different from Version? > > > from specfile: > > > %define download_version 0.70 > > > Name: shutter > > > Version: 0.70.2 > > > Why don't use Version instead of download_version? > > > > The real version is 0.70.2, but the tarball of source code which author > > provides is shutter-0.70. I do not know why the author do it. Maybe we should > > contract with author and persuade him to correct the version. > > > > Upstream provides 0.70.2 ( > http://shutter-project.org/wp-content/uploads/releases/tars/ ) OK！ I know I am wrong. Thank you for your notification. > > > 2] in %install you are creating directory named "0755" in bin/ and share/ > > > > Are there any problems? I think it is OK for us. > > > install command create this directories, please fix your %install section. > There is no reason to create them at first place. That is a good idea! > > 2. modules: It is not a good choice to remove them as I see. If we remove them, > > we will need to create packages for (File::Spec and Proc::Simple). If > > (File::Spec and Proc::Simple) upgrade to new version, it will be not compatible > > with shutter. So I think we should use the perl module which author offers. > > Just like some linux software with static libraries, It can provide the best > > compatibility with their software. > > It is much wise choice to have them as separate packages. It will provide much > more benefit to fedora. And as per my opinion it breaks following rule: > http://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_libraries > > I could very hardly imagine that next release of File::Spec and Proc::Simple > will be non-compatible with shutter. We could require specific version of > File::Spec or Proc::Simple packages. > It is same as for Perl-Goo-Canvas or Perl-Gnome2-Wnck. > > I have started creating package of File::Spec and Proc::Simple and will submit > them during today to help you. Yes. thank you too. So I need to remove /usr/share/shutter/resources/module/File and /usr/share/shutter/resources/module/Proc. But I think that /usr/share/shutter/resources/module/Shutter should not be removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review