Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505917 --- Comment #11 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-06-21 15:34:05 EDT --- For -3: * Macros consistency - Well, if you want to use %{__cat} or %{__sed} style, please use %{__make}, %{__rm} for consistency. * Timestamps - Would you consider to use --------------------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="install -p" --------------------------------------------------------------- for example to keep timestamps on installed files? * Misc issue --------------------------------------------------------------- %files devel %defattr(-,root,root,-) %doc --------------------------------------------------------------- - Empty %doc line is unneeded. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review