Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507030 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.lehtola@xxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jussi.lehtola@xxxxxx Flag| |fedora-review? --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-06-21 07:11:46 EDT --- - Your patch "0001-Use-the-chipmunk-shared-library-from-the-chipmunk-pa.patch" is incorrectly named. The name should be pymunk-(something).patch, e.g. pymunk-sharedlib.patch. - You need to change the patch from libfn = "/usr/lib/libchipmunk.so" to e.g. lib=`ls %{_libdir}/libchipmunk.so.*` sed -i "s|/usr/lib/libchipmunk.so|$lib|g" pymunk/libload.py in the setup phase, since a) the directory is wrong on multiarch systems b) the unversioned .so file symlink is provided by chipmunk-devel. - You can drop BR: python-setuptools if you're not targetting EPEL. - I'd remove completely the chipmunk_src directory in %setup: rm -rf chipmunk_src/ - Add README.txt, LICENSE.txt, PKG-INFO and THANKS.txt to %doc. - Change %{python_sitelib}/* to %{python_sitelib}/%{name}/ %{python_sitelib}/%{name}-*.egg-info/ - Drop CFLAGS="$RPM_OPT_FLAGS" from %build, as this is a noarch package. - Fix the newlines in %setup. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review