Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505917 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #9 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-06-20 12:24:39 EDT --- Some notes: * chrpath - We usually recommend to avoid to use chrpath as the means to delete rpath (and to add "chrpath" as BR(BuildRequires)) and instead recommend to try to remove rpath by modifying configure/libtool. For this packge: ----------------------------------------------------------------- %build %{__cat} <<'EOF' >libpuzzle.ini extension=libpuzzle.so EOF %configure --disable-static sed -i.rpath -e 's|^\(hardcode_libdir_flag_spec=\).*|\1""|' libtool sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool make %{?_smp_mflags} ....... ....... cd php/libpuzzle phpize %ifarch x86_64 ppc64 LDFLAGS="$LDFLAGS -L%{_builddir}/prelim2/usr/lib64"; export LDFLAGS %endif sed -i.rpath -e 's|\$ld_runpath_switch\$ai_p||g' configure %configure --with-libpuzzle=%{_builddir}/prelim2/usr sed -i.rpath -e 's|^\(hardcode_libdir_flag_spec=\).*|\1""|' libtool sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool make %{?_smp_mflags} ........ ........ ----------------------------------------------------------------- will remove rpath: http://koji.fedoraproject.org/koji/taskinfo?taskID=1426380 Ref: https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath * Requires - php-%{name} should have "Requires: php-common" for directory ownership issue * Usage of %_builddir ----------------------------------------------------------------- make DESTDIR=%{_builddir}/prelim2 install ----------------------------------------------------------------- - This is problematic is some other srpm use prelim2 directory. Please move this temporary directory to under %_builddir/%{name}-%{version} (and using "rm -rf %{_builddir}/prelim2" at clean is not desired) * Timestamps - Add the option 'INSTALL="install -p"' to 'make install' to keep timestamps on installed files. This method usually works for Makefiles generated by recent autotools. * Documents - There is no need to include the same document files to %doc of both libpuzzle and -devel packages. - Usually section 3 man pages are to explain functions, api or so and should belong to -devel subpackage. * %changelog - It is useful when importing this package into Fedora CVS if you put one line between each %changelog entry like: ------------------------------------------------------------------ * Thu Jun 18 2009 Andrew Colin Kissa <andrew@xxxxxxxxxxxxx> - 0.11-2 - Fix rpmlint issues * Sun May 14 2009 Andrew Colin Kissa <andrew@xxxxxxxxxxxxx> - 0.11-1 - Initial release ------------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review