Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506755 steve <steve@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steve@xxxxxxxxxxxx Blocks| |177841(FE-NEEDSPONSOR) --- Comment #2 from steve <steve@xxxxxxxxxxxx> 2009-06-20 09:45:12 EDT --- Hi ! Although i cannot sponsor you yet, I've reviewed your package. Here are some comments: a. Change the 'Source' tag URL to point to the correct upstream source URL[1]: -Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz +Source0: http://downloads.sourceforge.net/%{name}-%{version}.tar.gz b. rpmlint on the binary rpm returns a warning: [steve@laptop SPECS]$ rpmlint -i /home/steve/rpmbuild/RPMS/x86_64/tmux-0.8-1.fc10.x86_64.rpm tmux.x86_64: W: spurious-executable-perm /usr/share/man/man1/tmux.1.gz The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [steve@laptop SPECS]$ So, you'd want to modify the tmux-0.8-fixperms.patch to keep the permissions settings as they are and may be just remove the explicit ownership settings. c. It is preferable to not wildcard everything in %files in such a general manner. You may want to be specific for at least the %{_bindir} (since it is only 1 file each for bindir and mandir, there is no reason why you should have wildcards). Also, I'll set the FE-NEEDSPONSOR in the bug blocks[2] cheers, - steve [1] https://fedoraproject.org/wiki/Packaging/SourceURL#Referencing_Source [2] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_Your_Review_Request -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review