Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506971 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-06-20 04:19:47 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1426041 + rpmlint is silent for SRPM and for RPM. + source files match upstream url e04db7a114e5406e732037e51422c95528d0e22f CGI-Application-Plugin-DevPopup-1.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=9, 1 wallclock secs ( 0.06 usr 0.02 sys + 0.43 cusr 0.06 csys = 0.57 CPU) + Package perl-CGI-Application-Plugin-DevPopup-1.01-1.fc12.noarch Provides: perl(CGI::Application::Plugin::DevPopup) = 1.01 perl(CGI::Application::Plugin::DevPopup::HTTPHeaders) = 0.11 perl(CGI::Application::Plugin::DevPopup::Log) = 0.01 perl(CGI::Application::Plugin::DevPopup::Timing) = 0.91 Requires: perl(CGI::Application) >= 4.01 perl(HTML::Template) perl(IO::Scalar) perl(Time::HiRes) perl(base) perl(strict) perl(vars) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review