Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506939 --- Comment #4 from Harald Hoyer <harald@xxxxxxxxxx> 2009-06-19 12:29:10 EDT --- (In reply to comment #3) > - License - GPLv2+ > - License field in spec matches - *** > > *** The license in the code is GPLv2 or later; the spec tag should be GPLv2+. > It's also not present in most of the shell snippets; unsure what the > requirements are there. oh, yes, will change > - Spec in American English - *** > > generic package description: > This package requires everything, which is needed to build a generic > all purpose initramfs. > > Should probably be 'everything that is needed', without the comma. ok, will change > - Package needs ExcludeArch - *** > > *** The arch/noarch switching seems a bit odd. Can we just get a new util-linux > in so we don't need this? yes, we still have to have this for F-11 and have to wait a little bit for F-12 > The 'generic' package really should be some sort of Suggests/Enhances on the > main package. Alas, we can't do that yet. (Requiring to pull in nbd seems > wrong.) ok, then I rename it to dracut-buildall? > > That being said, if we don't have some sort of requirements on lvm2, raid, etc. > tools in the main package, the ordering won't be right on kernel installs, and > it will try to build a non-generic initramfs when the tools haven't yet been > installed that may be needed for that system. This needs solved before we ship > it. if the tools haven't been installed.. so you mean running a lvm / crypto / raid root without the tools ? > Other notes: > - dracut modules live in /usr. Do we need to be able to rebuild the initramfs > when /usr isn't present? good point! and plymouth? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review