[Bug 505507] Review Request: acheck - Check common localisation mistakes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505507


Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx>  2009-06-19 04:56:49 EDT ---

Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1424380
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
45651d7d33f69bbc2a19d674fd6a4f66302f2629  acheck_0.5.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package acheck-0.5.1-1.fc12.noarch =>
Provides: perl(ACheck::Common) perl(ACheck::FileType) perl(ACheck::Parser)
Requires: /usr/bin/perl perl(ACheck::Common) perl(ACheck::FileType)
perl(ACheck::Parser) perl(Config::General) perl(Data::Dumper) perl(Exporter)
perl(File::Copy) perl(File::Spec::Functions) perl(Getopt::Long) perl(IO::File)
perl(Term::ANSIColor) perl(Term::ReadLine) perl(Term::Size) perl(constant)
perl(locale) perl(strict) perl(vars)
+ Not a GUI application

Should:
1)Requires should be written as only
Requires:    perl(Text::Aspell), perl-gettext, %{name}-rules

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]