Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506185 --- Comment #9 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2009-06-17 15:34:44 EDT --- A few minor comments, 1. MUST: remove the ldconfig scriplets. ldconfig is needed only for shlibs, these aren't. 2. SHOULD: Source should include snap or svn<time_stamp> in the name, to match Release tag. For examples, see https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages 2a. poke/prod upstream to do a real release. :) 3. Kinda-sorta-should: make a parent virtual package that Requires all subpkgs, so one can do a simple: yum install bespin to get it all at once. (but, this is a matter of taste, up to you whether you want to do it or not). Heck, taking this to an extreme, if you also want to simplify matters further, including everything in a single pkg would be ok with me too. I don't consider any of these issues blockers, and can very well be fixed prior to building (before or after import). Being your first package, I'll add myself as comaintainer, and continue to advise as needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review