Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504709 --- Comment #4 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-06-15 12:46:58 EDT --- (In reply to comment #3) > Hi: Hi, thanks for the update! > (In reply to comment #2) > > ? The COPYING file you are packaging claims LGPL as the license. > > The source files say "You may redistribute it and/or modify it under the > > same license terms as Ruby." > > Meanwhile the license tag says "GPLv2 or Ruby" > > What's going on? :) > - Actually from the source code this is licensed under the same > license as ruby. Note that ruby is licensed under "GPLv2 or Ruby" > (well, a little complicated...), so the license tag should > be so. > Okay, but the COPYING file that is being packaged says LGPL, which is wrong according to what you say. Shouldn't we drop the wrong COPYING file? > > ? What are these BuildRequires(check)'s for? (I never saw them before. And > > Fedora guidelines don't mention them) > - The intention for this is that "These BuildRequires is needed only > for %check". > Thanks. Now the package fails to build on F-11 + rake --trace makemo /var/tmp/rpm-tmp.qYI3ky: line 41: rake: command not found I moved rubygem(rake) from BR(check) to regular BR, but then I got + rake --trace makemo /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31: command not found: allison --path I couldn't figure out what package provides allison on F-11. > > > * Ruby packaging guidelines say that the %build section of the specfile > > should be empty and the install should be performed with the command > > gem install --local --install-dir %{buildroot}%{gemdir} --force > > %{SOURCE0} > > Any reason why you are doing it differently? > - Actually it is under discussion whether "gem install" should completely > moved from %install to %prep or %build. This suggestion was from other > people but now I also think that "gem install" should not done at %install > directly > because: > - Actually when gem creates C module extension, rubygem guideline > already says "gem --install" should be done at %build because > of creating debuginfo rpm correctly (and this proposal was > from me) > - For this package, spec file contains %check. When gem is installed > under %buildroot, %check must be done also under %buildroot. > This is troublesome when %check (for this package "rake test") creates > some additional files because this will cause some unneeded filed > to be packaged or causes "installed but not packaged" error. > Do you know by any chance when these changes in the guidelines will be approved? I can't find the relevant discussion. Maybe I'm looking at the wrong mailing lists. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review