Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482216 --- Comment #14 from Rakesh Pandit <rpandit@xxxxxxxxxx> 2009-06-15 03:18:51 EDT --- (In reply to comment #10) > ? What is this file that gets packaged? > /usr/lib64/python2.6/site-packages/Mayavi-3.2.0-py2.6-nspkg.pth > Removed. (In reply to comment #11) > Here is the rest of the review: > > * As indicated by LICENSE_COLORBREWER.txt, parts of the file > enthought/mayavi/core/lut/pylab_luts.py is distributed under ASL 1.1 and it > should be added to the license tag. > Done. > * image_LICENSE.txt says > "Crystal: LGPL license as described in icon_LICENSE_CP.txt" > but icon_LICENSE_CP.txt contains the full text of GPLv2. Can you ask this > upstream for clarification? Even if they say it is LGPL, we cannot ship this > icon_LICENSE_CP.txt file as it is wrong. > Will remove after asking from upstream after clearing doubts. > * image_LICENSE_OOo is LGPLv3+ and this has to be added to the license tag. > I think LGPLv2+ (as it has or later) covers LGPLv3+ also. Or am I wrong ? > * docs/mayavi2.man should be packaged. Is this a man1? Yes included. > > ? Is the documentation under docs/source/ worth packaging? Yes included Will updated, once I get confirmation from upstream about license. Thanks, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review