Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504709 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-06-15 02:42:24 EDT --- Here are my notes for this package: ! The timestamps in the source gem file are all wrong. Please ask upstream to correct this. ? rpmlint says rubygem-gettext_activerecord-doc.noarch: W: no-documentation Shouldn't the contents of this package be marked %doc ? * Please remove the binary .mo files in %prep ? The COPYING file you are packaging claims LGPL as the license. The source files say "You may redistribute it and/or modify it under the same license terms as Ruby." Meanwhile the license tag says "GPLv2 or Ruby" What's going on? :) ? What are these BuildRequires(check)'s for? (I never saw them before. And Fedora guidelines don't mention them) * A package must not contain any duplicate files in the %files listing. build.log says warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/gettext_activerecord-2.0.4/test/test_parser.rb warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/gettext_activerecord-2.0.4/test/test_validations.rb * The indentation seems wrong with this line * extract messages from models with the rake task. * Ruby packaging guidelines say that the %build section of the specfile should be empty and the install should be performed with the command gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} Any reason why you are doing it differently? - koji rawhide build seems fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=1414345 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review