Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vigra - Generic Programming for Computer Vision https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204975 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: vigra - |Review Request: vigra - |Generic Programming for |Generic Programming for |Computer Vision |Computer Vision CC| |panemade@xxxxxxxxx ------- Additional Comments From panemade@xxxxxxxxx 2006-09-05 07:30 EST ------- {Not Official Reviewer} - rpmlint on SOURCE rpm is NOT silent rpmlint -iv vigra-1.4.0-1.src.rpm I: vigra checking W: vigra invalid-license MIT/X11 The value of the License tag is invalid. Valid values are: "Academic Free License", "Adaptive Public License", "Apache License", "Apache Software License", "Apple Public Source License", "Artistic", "Attribution Assurance License", "BSD", "Computer Associates Trusted Open Source License", "CDDL", "CPL", "CUA Office Public License", "EU DataGrid Software License", "Eclipse Public License", "Educational Community License", "Eiffel Forum License", "Entessa Public License", "Fair License", "Frameworx License", "GPL", "LGPL", "Historical Permission Notice and Disclaimer", "IBM Public License", "Intel Open Source License", "Jabber Open Source License", "Lucent Public License", "MIT", "CVW License", "Motosoto License", "MPL", "NASA Open Source Agreement", "Naumen Public License", "Nethack General Public License", "Nokia Open Source License", "OCLC Research Public License", "Open Group Test Suite License", "Open Software License", "PHP License", "Python license", "Python Software Foundation License", "QPL", "RealNetworks Public Source License", "Reciprocal Public License", "Ricoh Source Code Public License", "Sleepycat License", "Sun Industry Standards Source License", "Sun Public License", "Sybase Open Watcom Public License", "University of Illinois/NCSA Open Source License", "Vovida Software License", "W3C License", "wxWindows Library License", "X.Net License", "Zope Public License", "zlib License", "Design Public License", "GFDL", "LaTeX Project Public License", "OpenContent License", "Open Publication License", "Public Domain", "Ruby License", "SIL Open Font License", "Charityware", "Commercial", "Distributable", "Freeware", "Non-distributable", "Proprietary", "Shareware". If the license is close to an existing one, you can use '<license> style'. => I think you better write MIT only in License tag W: vigra rpm-buildroot-usage %build --docdir=%{buildroot}/usr/share/doc/%{name}-%{version} $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will break short circuiting. E: vigra configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir}. Many things need to be considered in this package SPCE file. I have modified SPEC file will post it -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review