Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505867 --- Comment #1 from Chitlesh GOORAH <chitlesh@xxxxxxxxx> 2009-06-14 12:18:06 EDT --- #1: typo in comments # Prog is GPLv2 - #####Elements###### are Creative Commons Attribution The package in general is ok, however I feel it is too software oriented and lacks its professional touch in terms of the wordings. #2: Inorder to maintain consistency between other FEL packages, the sub-packge -elements should be called "-symbols", (e.g geda-symbols, soon kicad-symbols). #3: use of Electronic menu structure Add Requires: electronics-menu and in desktop-file-install --add-category "Electronics" \ remove the office category #4: Since we want FEL to be as professional as possible, i would like you to rephrase the %description so that it doesn't feel too geeky QElectroTech helps to design electric schematics. It includes both a schematic editor and an symbol editor. diagram was replaced by schematic element was replaced by symbol Maybe you can ask upstream to take this wordings into account as well. The more it uses similar words, the easier it will be for fedora ambassadors for market qelectrotech around the world Same for the summary, replace "diagrams" by schematics. #5: Group: Applications/Engineering #6: missing for subpackage -elements Requires: qelectrotech = %{version}-%{release} #7: is there any reason for %if 0%{?fedora} >= 11 BuildArch: noarch %endif if it is only for symbols in the XML format then it should be by default noarch ? #8 update the spec file, I'll approve it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review