Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489686 --- Comment #46 from Denis Arnaud <denis.arnaud_fedora@xxxxxxx> 2009-06-13 12:16:47 EDT --- 1. The following line: Requires: libstdc++-devel, atlas-devel, lapack-devel, boost-devel should be removed, as the corresponding dependencies are already taken into account by the 'BuildRequires:' line, and as the 'Requires:' dependencies are automatically calculated: https://fedoraproject.org/wiki/Packaging/Guidelines#Requires . 2. I would add a "-f" (force) flag in the following line: rm examples/Makefile.cmake But it may be due to my paranoia :) 3. Since you are the main upstream developer, I would suggest (but that is not at all a Fedora requirement) to burry the header files in a specific directory, resulting, after the installation, into: %{_includedir}/armadillo/armadillo %{_includedir}/armadillo/bits %{_includedir}/armadillo/armadillo_itpp That way, you would have to add the armadillo directory prefix when you include Armadillo headers. For instance: #include <armadillo/bits/Mat_meat.hpp> instead of #include <armadillo_bits/Mat_meat.hpp> But that is only a suggestion! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review