Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: whysynth-dssi - DSSI software synthesizer plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190029 ------- Additional Comments From green@xxxxxxxxxx 2006-09-04 18:30 EST ------- (In reply to comment #5) > You use > %defattr(-,root,root) > instead of > %defattr(-,root,root,-) > - is this intentionally? No - fixed. > Why is there no desktop file as in > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 ? If you add it, > please not inline but in an extra file. There's no icon. I'll create one. It's still not in the SPEC file I've posted. > > Why do you use '%makeinstall' instead of the favoured 'make install > DESTDIR="$RPM_BUILD_ROOT"'? Fixed. Spec URL: http://people.redhat.com/green/FE/FC5/whysynth-dssi.spec SRPM URL: http://people.redhat.com/green/FE/FC5/whysynth-dssi-20060122-4.src.rpm (which is what I meant to write in my previous reply) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review