Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494219 --- Comment #2 from Paul Howarth <paul@xxxxxxxxxxxx> 2009-06-11 11:09:33 EDT --- Review Guidelines ================= - rpmlint clean - package name is OK and is consistent with existing trac plugin packages in Fedora - spec file name consistent with package name - package meets guidelines - Beerware license is OK for Fedora - correct "Copyright only" License field used in spec - no detached license file to include - spec file written in English and is legible - source pulling instructions are missing "-r" option to set svn revision - sources from SRPM match sources from upstream VCS - package builds OK in mock for Fedora 10 (x86_64) - buildreqs fine - no locale data, libs, or devel files to worry about - not relocatable - directory ownership is fine - no duplicate entries in %files list - %defattr(...) and %clean present and correct - macro usage is consistent - code, not content - no large docs (in fact hardly any docs at all!) - docs don't affect runtime - not a GUI app, no .desktop file needed - %install section properly cleans buildroot - filenames all valid UTF-8 - no scriptlets needed - package appears to work as advertised - no subpackages used - no file dependencies Notes ===== Perhaps add comment that python-setuptools runtime dependency is needed for pkg_resources import? Please include contrib/sessionstore_convert.py as %doc (see http://www.mailinglistarchive.com/trac-users@xxxxxxxxxxxxxxxx/msg03696.html) Please add -r $svnrel to svn export instructions -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review