Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501573 --- Comment #9 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2009-06-10 19:26:38 EDT --- > 1) It contains a binary that now pulls in postgres and mysql libs: > Is that an okay practice? Ideally a ndoutils-mysql package and an > ndoutils-pgsql would be better but there is not an obvious method > without building things twice and renaming the results from > the first compile. What to do? > I guess in this case, the easiest would be to compile the module once for mysql and once for postgres, rename the modules, and put them in 2 sub-packages, so the packages only pull the deps for one of them. Or you may provide support for only one, not both, but someday someone will probably request support for the other. Maybe the real reviewer will have more insight than me on this issue. > 2) Is there a way to disable AutoReqProv just for the > /usr/share/docs/nodutils-* ? > There are some example scripts in there that should probably > not pull in extra perl dependencies? > Requires can be filtered, but what you really want is remove exec perms on the scripts, so they don't get parsed. This will clear a good chunk of the rpmlint errors below : ndoutils.i386: W: spurious-executable-perm /usr/share/doc/ndoutils-1.4/db/upgradedb ndoutils.i386: W: non-conffile-in-etc /etc/rc.d/init.d/ndo2db ndoutils.i386: E: non-executable-script /etc/rc.d/init.d/ndo2db 0644 ndoutils.i386: W: non-standard-uid /var/log/ndoutils nagios ndoutils.i386: W: spurious-executable-perm /usr/share/doc/ndoutils-1.4/db/prepsql ndoutils.i386: W: non-standard-uid /var/run/ndoutils nagios ndoutils.i386: W: non-standard-uid /var/cache/ndoutils nagios ndoutils.i386: W: spurious-executable-perm /usr/share/doc/ndoutils-1.4/db/installdb ndoutils.i386: W: log-files-without-logrotate /var/log/ndoutils ndoutils.i386: W: doc-file-dependency /usr/share/doc/ndoutils-1.4/db/upgradedb perl(FindBin) ndoutils.i386: W: doc-file-dependency /usr/share/doc/ndoutils-1.4/db/installdb perl(FindBin) ndoutils.i386: W: doc-file-dependency /usr/share/doc/ndoutils-1.4/db/upgradedb /usr/bin/perl ndoutils.i386: W: doc-file-dependency /usr/share/doc/ndoutils-1.4/db/installdb /usr/bin/perl ndoutils.i386: W: doc-file-dependency /usr/share/doc/ndoutils-1.4/db/upgradedb perl(Getopt::Std) ndoutils.i386: W: doc-file-dependency /usr/share/doc/ndoutils-1.4/db/installdb perl(Getopt::Std) ndoutils.i386: W: doc-file-dependency /usr/share/doc/ndoutils-1.4/db/upgradedb perl(strict) ndoutils.i386: W: doc-file-dependency /usr/share/doc/ndoutils-1.4/db/installdb perl(strict) ndoutils.i386: W: doc-file-dependency /usr/share/doc/ndoutils-1.4/db/upgradedb perl(DBI) ndoutils.i386: W: doc-file-dependency /usr/share/doc/ndoutils-1.4/db/installdb perl(DBI) ndoutils.i386: E: init-script-non-executable /etc/rc.d/init.d/ndo2db ndoutils.i386: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/ndo2db ndoutils.i386: W: no-reload-entry /etc/rc.d/init.d/ndo2db ndoutils.i386: W: incoherent-init-script-name ndo2db ndoutils.src: W: strange-permission ndo2db.initd 0755 3 packages and 0 specfiles checked; 2 errors, 22 warnings. use 'rpmlint -I some-error' for more information. Don't bother for at least these 3, in this case, it's expected : ndoutils.i386: W: non-standard-uid /var/log/ndoutils nagios ndoutils.i386: W: non-standard-uid /var/run/ndoutils nagios ndoutils.i386: W: non-standard-uid /var/cache/ndoutils nagios After that, you mostly need to work on the initscript and the package should then be in a reasonably good shape. Btw, the installation instructions want to put the conf file in the nagios conf dir (/etc/nagios). Have you considered doing this or do you want to keep the conf in their own subdir ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review