Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502065 --- Comment #3 from Iain Arnell <iarnell@xxxxxxxxx> 2009-06-09 23:49:50 EDT --- (In reply to comment #2) > the game, and they are all marked %config(noreplace). The nonstandard dir > permissions are copied from nethack, so they're fine. Just about everything was copied from nethack.... > But the dangerous > commands need to be dealt with. Looking through the scriptlets, it appears you > need to add these to the spec file: > > Requires(post): coreutils, mkfontdir > Requires(preun): coreutils And there was me thinking that rpmlint just meant "rm" and "ln" were potentially dangerous. The necessary requires for scriptlets are added. > Is mkfontdir really a BuildRequires? I only see it invoked in %post. Ack. Dropped as a BR. > X: packaging guidelines -- see the section on scriptlets. I believe that the > body of your %post script should be wrapped in this: > > if [ $1 -eq 1 ]; then > ... > fi I think that %post should also run on upgrade - just in case something changes with the fonts. > and the body of your %preun script should be wrapped in this: > > if [ $1 -eq 0 ]; then > ... > fi But, of course, this one is needed - otherwise upgrades are broken. Both now "exit 0" as well, just in case. > OK: desktop file. However, not this sentence from the Packaging guidelines: > > For new packages, do not apply a vendor tag to desktop files. Ack. > OK: package builds in mock (only checked fedora-rawhide-x86_64) > --: package builds on all supported arches (unable to check) The scratch-build in koji shows that it builds on all primary arches. > OK: package functions as described (only minimal testing ... just wait until > later!) And the resulting build runs on ppc too (now _that's_ why I got a PS3 - nethack and slashem on the big screen!) Spec URL: http://fedorapeople.org/~iarnell/review/slashem.spec SRPM URL: http://fedorapeople.org/~iarnell/review/slashem-0.0.8-0.2.E0F1.fc12.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1402932 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review