Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478759 Brennan Ashton <bashton@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #26 from Brennan Ashton <bashton@xxxxxxxxxxxxxxxxx> 2009-06-09 15:37:22 EDT --- [PASS] source files match upstream [PASS] package meets naming and versioning guidelines. [PASS] specfile is properly named [PASS] dist tag is present. [PASS] build root is correct. [PASS] license field matches the actual license. [PASS] license is open source-compatible. [PASS] latest version is being packaged. [PASS] BuildRequires are proper. [PASS] %clean is present. [N/A] package builds in mock. Building with a koji build of perl-Verlog [PASS] package installs properly. debuginfo package looks complete. [PASS] %check is present and all tests pass: [PASS] owns the directories it creates. [PASS] doesn't own any directories it shouldn't. [PASS] no duplicates in %files. [PASS] file permissions are appropriate. [PASS] no scriptlets present. [PASS] code, not content. [PASS] %docs are not necessary for the proper functioning of the package. I Approve with the perl-Verlog in koji. Lane is right, you should add the new version requirement of perl-Verlog to the spec. After this go ahead with CVS request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review