[Bug 504809] Review Request: system-config-selinux - SELinux configuration GUI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504809





--- Comment #3 from Bill Nottingham <notting@xxxxxxxxxx>  2009-06-09 13:35:51 EDT ---
1. ...
%install
make install DESTDIR=%{buildroot}
ln -sf consolehelper %{buildroot}%{_bindir}/system-config-selinux
...
desktop-file-install --vendor fedora \
 --dir %{buildroot}%{_datadir}/applications \
 %{SOURCE2}
rm -rf %{buildroot}

Having rm -rf %{buildroot} as the last line of install is almost certainly NOT
what you want.

2. Spec references selinux-polgengui.desktop, not in the source RPM.

3. It uses consolehelper

4. How much of this is something we really need a GUI for?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]