Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504809 --- Comment #1 from Jaroslav Reznik <jreznik@xxxxxxxxxx> 2009-06-09 11:32:25 EDT --- Quick overview before deeper review (I'll finish it later): - version (2.0.62) and release (13) don't match changelog ones (1.0.0-1) - inconsistent usage of %{buildroot} and $RPM_BUILD_ROOT - use only one - use lowercase SPEC filename - no %doc RPMLint rpmlint System-config-selinux.spec System-config-selinux.spec: E: no-cleaning-of-buildroot %install System-config-selinux.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 40, tab: line 1) 0 packages and 1 specfiles checked; 1 errors, 1 warnings. rpmlint System-config-selinux-2.0.62-13.fc12.src.rpm system-config-selinux.src: W: non-coherent-filename System-config-selinux-2.0.62-13.fc12.src.rpm system-config-selinux-2.0.62-13.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review