Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504489 --- Comment #2 from François Kooman <fkooman@xxxxxxxxx> 2009-06-08 14:14:03 EDT --- Spec URL: http://fkooman.fedorapeople.org/proguard/proguard.spec SRPM URL: http://fkooman.fedorapeople.org/proguard/proguard-4.3-2.fc11.src.rpm (In reply to comment #1) > ! Please explain in the specfile as comments what Sources 1-3 are for. Done. > ! Not a blocker, but in the docs/ and examples/ directories, there are html, > xml and pro files that refer to /usr/local/. You might want to fix them. I've included a README.dist now. > ? Any reason why you don't put the jar files directly in /usr/share/java/ ? Yes, Packaging:Java says something about this: """ 1. If the number of provided JAR files exceeds two, you must place them into a sub-directory. """ Maybe I misread/misunderstood? > * If a package contains a GUI application, then it needs to also include a > properly installed .desktop file. Done. The problem now is that I can't find a suitable icon for ProGuard anywhere. For now I use the "java" icon. > ! You need to specify a specific java version in BR and R. See: > http://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires > In your case this ought to be 1.5 This doesn't seem mandatory the way I read this? Also it is not mentioned in the "ant" template I used to create this spec file. Furthermore, I tried to compile it with "-source 1.4" and that also works? > * GCJ AOT bits SHOULD be built and included in packages. Since this package > builds with java 1.5, this will bring great performance improvements on ppc* > architectures. Please follow: > http://fedoraproject.org/wiki/Packaging/GCJGuidelines I did this now. However, rpmbuild gives some warnings now: + /usr/bin/aot-compile-rpm /usr/lib/python2.6/site-packages/aotcompile.py:18: DeprecationWarning: the md5 module is deprecated; use hashlib instead import md5 aot-compile-rpm: warning: subsetted /home/fkooman/rpmbuild/BUILDROOT/proguard-4.3-2.fc11.x86_64/usr/share/java/proguard/proguardgui.jar aot-compile-rpm: warning: subsetted /home/fkooman/rpmbuild/BUILDROOT/proguard-4.3-2.fc11.x86_64/usr/share/java/proguard/retrace.jar WARNING: Error loading security provider org.bouncycastle.jce.provider.BouncyCastleProvider: java.lang.ClassNotFoundException: org.bouncycastle.jce.provider.BouncyCastleProvider not found in gnu.gcj.runtime.SystemClassLoader{urls=[file:./], parent=gnu.gcj.runtime.ExtensionClassLoader{urls=[], parent=null}} WARNING: Error loading security provider org.bouncycastle.jce.provider.BouncyCastleProvider: java.lang.ClassNotFoundException: org.bouncycastle.jce.provider.BouncyCastleProvider not found in gnu.gcj.runtime.SystemClassLoader{urls=[file:./], parent=gnu.gcj.runtime.ExtensionClassLoader{urls=[], parent=null}} rpmlint is also not totally happy: [fkooman@localhost x86_64]$ rpmlint proguard-4.3-2.fc11.x86_64.rpm proguard.x86_64: W: unstripped-binary-or-object /usr/lib64/gcj/proguard/proguard.jar.so 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [fkooman@localhost x86_64]$ and the one that is due to GCJ (which can be ignored): proguard.spec:118: W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name} > Can you review my package (bug #504521 )? It is java too. It seems someone is already interested in reviewing it. I added myself to the CC of the bug anyway and look through it soon. Thanks for your review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review