Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504456 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-06-08 00:27:56 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1397614 + rpmlint is silent for SRPM and for RPM. + source files match upstream url c545632cf924e5733230beecc03b23e565b034c0 MooseX-SemiAffordanceAccessor-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=12, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.19 cusr 0.04 csys = 0.25 CPU) + Package perl-MooseX-SemiAffordanceAccessor-0.03-1.fc12.noarch => Provides: perl(MooseX::SemiAffordanceAccessor) = 0.03 perl(MooseX::SemiAffordanceAccessor::Role::Attribute) Requires: perl(Moose) >= 0.55 perl(Moose::Exporter) perl(Moose::Role) perl(Moose::Util::MetaRole) perl(MooseX::SemiAffordanceAccessor::Role::Attribute) perl(strict) perl(warnings) + Not a GUI application APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review