Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225698 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mclasen@xxxxxxxxxx, | |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #5 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-06-07 23:14:52 EDT --- I reviewed this package. It just needs very trivial fixes: * rpmlint says dmidecode.src: W: no-version-in-last-changelog dmidecode.src:11: E: buildprereq-use /usr/bin/aclocal /usr/bin/automake /usr/bin/autoconf dmidecode.src:13: W: unversioned-explicit-obsoletes kernel-utils dmidecode.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5) dmidecode-debuginfo.x86_64: W: no-version-in-last-changelog dmidecode.x86_64: W: no-version-in-last-changelog dmidecode.x86_64: W: obsolete-not-provided kernel-utils These are all easy to fix. Use for instance rpmlint -I buildprereq-use to see what the complaint is about. * The release tag is a mess. Can we continue with the usual convention?: 2%{?dist} * Source0 must be full URL (with %{name} and %{version} macros) - Buildroot is improper but it will be obsoleted soon so it's not a problem. * We prefer %defattr(-,root,root,-) * Parallel make must be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment. I added mclasen to the CC since he made the last known build. Sorry if this was not desired. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review